ci: dev-depend on lutaml-model for the YAML bridge specs - #775
Merged
Merged
Conversation
lib/interscript/isc/yaml_bridge.rb hard-requires lutaml/model; the round-trip specs exercise it and fail with LoadError on CI, where the gem was never installed. Added as a dev dependency only — the gemspec doesn't declare it (flagged for the owner: the isc/model autoload fails without the gem in a default install).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 9 of the 28 remaining rake failures (round_trip: LoadError
cannot load lutaml/model).lib/interscript/isc/yaml_bridge.rbandlib/interscript/isc/model.rbhard-require "lutaml/model", but nothing installs it — the round-trip specs pass wherever the gem happens to be globally present and LoadError everywhere else. This adds it as a Gemfile dev dependency (no downstream resolver impact).Owner note: the gemspec doesn't declare
lutaml-model, so a defaultgem install interscript+ any touch of theIsc::Model/Isc::YamlBridgeautoloads fails. Whether to addspec.add_dependency "lutaml-model"or make the bridge optional is a requirements decision I'm leaving to you.