Repository navigation
fix: request local network access before connecting - #13
Merged
Merged
Conversation
Agent-Id: agent-e58673fb-9373-4771-84e4-d284a64068b5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android 17 blocks local network connections for apps targeting API 37 until they declare and receive
ACCESS_LOCAL_NETWORK. The companion previously started pairing and restored sessions without requesting that permission.Add the manifest permission and gate connection setup behind the Android 17 runtime grant. Keep incoming pairing intents pending until access is allowed, provide retry and Android settings controls after denial, and recheck permission when returning to the app. Older Android versions continue directly to the connection UI.
Validation:
./gradlew ktlintFormat build ktlintCheck detekt test :app:assembleDebugpassed; 466 unit tests, zero failures or skips.The physical denial dialog was not independently completed. Emulator UI tests and older physical Android devices were not tested.