Repository navigation
fix(winrwe): prevent OS command injection via unquoted filenames in RW.exe calls - #117
Closed
prakashb72 wants to merge 2 commits into
Closed
prakashb72 wants to merge 2 commits into
prakashb72 wants to merge 2 commits into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| # Built-in imports | ||
| import os | ||
| import binascii | ||
| import subprocess |
| if log_file is not None: | ||
| arguments.append("/LogFile={}".format(self._validate_path(log_file))) | ||
| arguments.append("/Command={}; RwExit".format(command)) | ||
| return subprocess.run(arguments, shell=False).returncode |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The security boundary lacks regression tests for malicious paths and subprocess argument handling.
Review effort: Balanced
Findings: 1
What changed in this PR
Replaces shell-based RW.exe execution with validated, argument-based subprocess calls to prevent command injection.
Changes:
- Adds centralized path validation and RW.exe execution.
- Migrates memory, reset, and I/O commands away from
os.system.
| File | Description |
|---|---|
src/xmlcli/access/winrwe/winrwe.py |
Validates paths and invokes RW.exe without a shell. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| def _validate_path(filename): | ||
| # RW.exe parses its own /Command string, so separators and quotes must not appear in a path. | ||
| filename = os.fspath(filename) | ||
| if any(character in filename for character in ';"\r\n'): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.