Repository navigation
Fix OS command injection in WinRweAccess via os.system → subprocess.run(shell=False) - #114
Open
sys-xmlcli wants to merge 4 commits into
Open
sys-xmlcli wants to merge 4 commits into
sys-xmlcli wants to merge 4 commits into
Conversation
prakashb72
approved these changes
Sep 28, 2026
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| # Built-in imports | ||
| import os | ||
| import binascii | ||
| import subprocess |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Staging fails when the caller’s filename aliases the configured temporary file.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Replaces shell-based RW.exe execution to prevent command injection.
Changes:
- Uses
subprocess.runwith structured arguments. - Validates RW command paths.
- Stages caller files through a trusted temporary path.
| File | Description |
|---|---|
src/xmlcli/access/winrwe/winrwe.py |
Secures RW.exe invocation and file handling. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.