Repository navigation
CMake: Add option ENABLE_INSTALL - #351
Merged
Merged
Conversation
install() always ran, including install(EXPORT). Embedders that add_subdirectory() TinyCBOR then write headers into the parent prefix, and CMake may refuse the export when the tinycbor target inherited foreign LINK_LIBRARIES. Route every install() through tinycbor_install so the option can skip those rules. Default is ON.
thiagomacieira
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ENABLE_INSTALL(default ON) so embedders usingadd_subdirectory()/ FetchContent can skip TinyCBOR's install rules.install()through atinycbor_installhelper (headers, pkgconfig, export, tools)cmake --installis unchanged.When TinyCBOR is pulled in as a subdirectory, its
install()commands write into the parent prefix.install(EXPORT)can also fail if thetinycbortarget inheritedLINK_LIBRARIESfrom the parent: those targets are not in TinyCBOR's export set.