ci: use npm ci --ignore-scripts in sps - #2775
Open
aryamohanan wants to merge 4 commits into
Open
aryamohanan wants to merge 4 commits into
aryamohanan wants to merge 4 commits into
Conversation
aryamohanan
force-pushed
the
test-cve
branch
2 times, most recently
from
September 17, 2026 13:19
e55d659 to
d646dd9
Compare
aryamohanan
force-pushed
the
test-cve
branch
from
September 18, 2026 10:44
d646dd9 to
fc82a3e
Compare
aryamohanan
marked this pull request as ready for review
September 18, 2026 12:01
kirrg001
reviewed
Sep 18, 2026
|
|
||
| cd "$WORKSPACE/$(load_repo app-repo path)" | ||
| npm install --loglevel warn --foreground-scripts | ||
| npm ci --loglevel warn --ignore-scripts |
Contributor
There was a problem hiding this comment.
Using npm ci has no effect in our test env right now.
Contributor
Author
There was a problem hiding this comment.
True, but I think keeping npm ci is good practice here. It ensures deterministic builds by adhering to package-lock.json and is recommended for CI.
Contributor
There was a problem hiding this comment.
Yeah but you did not switch to npm ci for the other parts, because we do run that locally too.
So its a bit inconsistent right now.
You could use isCI helper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
npm install --foreground-scriptswithnpm ci --ignore-scriptsfor dependency installs in the Tekton pipeline.npm ciinstalls strictly from package-lock.json, preventing a compromised newer version from silently resolving in--ignore-scriptsblocks preinstall/postinstall/install lifecycle hooks from running in CI, closing the exact execution vector used by the CHAINDROP/Shai-Hulud npm supply chain worm (Aug 2026)--foreground-scriptsadded as part of f558accSince we ignore lifecycle scripts during installation, this option is no longer needed, so I removed it.
ref : https://nodejs.org/learn/getting-started/security-best-practices#supply-chain-attacks
https://www.elastic.co/security-labs/shai-hulud-chaindrop-npm-supply-chain#recommendations-how-to-respond-to-the-shai-hulud-compromise