Repository navigation
fix(frontend): hover highlight without a fade - #4075
Merged
Merged
Conversation
Kadrian
marked this pull request as ready for review
October 8, 2026 14:28
Kadrian
enabled auto-merge
October 8, 2026 14:28
thoniTUB
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hover highlight without a fade on menu items, list rows and combobox options.
Sweeping the pointer over a long menu felt laggy. Two things add up: react-aria moves focus to the hovered item and re-renders every item of the menu on each hover (adobe/react-spectrum#5897, no fix upstream yet; a one-line comment in Menu.tsx points there), and our 100 ms background transition made the highlight trail the cursor on top of that. The transition is the part in our hands.
transition-[background-color]removed from MenuItem, GridList rows and ComboBox options, so all three highlight the same wayUiComponents/Menu › ManyItemswith 200 items to re-test after react-aria bumps