Repository navigation
Conversation
Backport of a480ee6 (19.0, ingadhoc#436). Granting base.group_user to the parent menus without group was done while loading the menus, but on 18.0 that runs inside readonly routes (/web/session/get_session_info, the webclient), so the write breaks its cursor with "cannot execute INSERT in a read-only transaction". The request is retried with a read/write cursor, but the failed query is already logged as an error, which turns a test run red: each test rolls the write back. Doing it on _register_hook keeps the case covered and runs on a read/write cursor. The field is groups_id on 18.0. (cherry picked from commit a480ee6)
Contributor
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tarea: https://www.adhoc.inc/odoo/project.task/77384
Backport a 18.0 de #436 (a480ee6, 19.0).
Qué duele
portal_backendles dabase.group_usera los menús padre sin grupo dentro deload_menus. En 18.0 eso corre en rutas de solo lectura (/web/session/get_session_info, el webclient), así que elwriterompe el cursor:La request se reintenta y termina bien, pero la query fallida queda logueada como error y eso pone en rojo la corrida de tests. Cada test hace rollback del
write, así que se repite en cada uno. Hoy lo dispararunbot-obade Tuqui-AI/odoo-addons#191, cuyos tests llaman aget_session_info.Qué cambia
Lo mismo que en 19.0: el
writepasa deload_menusa_register_hook, que corre con cursor de escritura al cargar el registry. Único ajuste: en 18.0 el campo esgroups_id.test_load_menus_cache, que existe solo en 18.0, sigue valiendo:load_menusya no escribe nunca.Cómo se prueba
La rama tiene el mismo nombre que la de Tuqui-AI/odoo-addons#191 e ingadhoc/odoo-saas#1026, así que runbot arma una sola build. Con este fix,
runbot-obade esa build no tiene que loguear elINSERTfallido.Para mergear
Ya está en 19.0:
@roboadhoc r+ nobump fw=no.