Repository navigation
Remove unused webpack devDependency - #19
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
VerificationNode.js 24.21.0, run on 13ec391.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removed
webpackfromdevDependenciesand dropped the unusedwebpack = require 'webpack'fromwebpack.config.coffee.Why
The top-level
webpackis not used by the build.gulp buildrunsgulp-webpack, which loads the webpack in its own dependencies (>=1.9.0 <2.0.0-0, resolved to 1.15.0) because the gulpfile does not pass a webpack instance to it.The top-level
webpackwas only required inwebpack.config.coffee, and the variable was never used.Because of this, bumping the top-level
webpackhas no effect on the build.#17 (webpack 1.15.0 → 5.112.0) is green only because CI does not run the build; with #17 applied,
gulp buildstill reportsVersion: webpack 1.15.0.Once this is merged, Dependabot will close #17 because the dependency no longer exists.
How
dist/is not regenerated, as in Make gulp build work with gulp 5 #14 and Remove unused exports-loader #18.dist/bundle.jsproduces only the diffs already described in those PRs: the function wrapping (Make gulp build work with gulp 5 #14) and the removal of the exports-loader comments (Remove unused exports-loader #18).dist/parser.jsdoes not change.path = require 'path'inwebpack.config.coffeeis also unused, but is left as is to keep this PR to thewebpackdependency.package.jsonandwebpack.config.coffeeare the only files changed.Refs
gulp-webpack, while checking Bump webpack from 1.15.0 to 5.112.0 #17.