Skip to content

Remove unused webpack devDependency - #19

Merged
atm-snag2 merged 1 commit into
masterfrom
remove-direct-webpack-dependency
Oct 26, 2026
Merged

atm-snag2 merged 1 commit into
masterfrom
remove-direct-webpack-dependency

Conversation

@atm-snag2

Copy link
Copy Markdown
Contributor

What

Removed webpack from devDependencies and dropped the unused webpack = require 'webpack' from webpack.config.coffee.

Why

The top-level webpack is not used by the build.
gulp build runs gulp-webpack, which loads the webpack in its own dependencies (>=1.9.0 <2.0.0-0, resolved to 1.15.0) because the gulpfile does not pass a webpack instance to it.
The top-level webpack was only required in webpack.config.coffee, and the variable was never used.

Because of this, bumping the top-level webpack has no effect on the build.
#17 (webpack 1.15.0 → 5.112.0) is green only because CI does not run the build; with #17 applied, gulp build still reports Version: webpack 1.15.0.

Once this is merged, Dependabot will close #17 because the dependency no longer exists.

How

Refs

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@atm-snag2 atm-snag2 self-assigned this Oct 26, 2026
@atm-snag2

Copy link
Copy Markdown
Contributor Author

Verification

Node.js 24.21.0, run on 13ec391.

npm i / npm test

npm i completed. npm test passed twice in a row:

  12 passing (6ms)

npm ls webpack

Only the webpack under gulp-webpack remains:

tag-data-parser@0.1.0
└─┬ gulp-webpack@1.5.0
  └── webpack@1.15.0

npx gulp build

[14:27:36] Starting 'webpack'...
[14:27:36] Version: webpack 1.15.0
           Asset     Size  Chunks             Chunk Names
./dist/bundle.js  18.8 kB       0  [emitted]  main
[14:27:36] Finished 'webpack' after 86 ms
[14:27:36] Finished 'build' after 102 ms

dist/parser.js is unchanged. The diff in dist/bundle.js is only the function wrapping (#14) and the removal of the exports-loader comments (#18):

-/***/ function(module, exports, __webpack_require__) {
+/***/ (function(module, exports, __webpack_require__) {
 
 	window.TagDataParser = __webpack_require__(1);
 
 
-	/*** EXPORTS FROM exports-loader ***/
-
-
-/***/ },
+/***/ }),
 /* 1 */
-/***/ function(module, exports) {
+/***/ (function(module, exports) {
@@ -685,8 +682,5 @@
-	/*** EXPORTS FROM exports-loader ***/
-
-
-/***/ }
+/***/ })

The rebuilt dist/ is not committed.

#17 head (162a3d0)

With webpack@5.112.2 installed at the top level, npx gulp build still runs on webpack 1.15.0:

├─┬ gulp-webpack@1.5.0
│ └── webpack@1.15.0
└─┬ webpack@5.112.2

[14:29:43] Version: webpack 1.15.0

@atm-snag2
atm-snag2 marked this pull request as ready for review October 26, 2026 05:33
@atm-snag2
atm-snag2 requested a review from a team as a code owner October 26, 2026 05:33
@atm-snag2
atm-snag2 requested review from P-SiZK and removed request for a team October 26, 2026 05:33

@P-SiZK P-SiZK left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@atm-snag2
atm-snag2 merged commit 5c7b279 into master Oct 26, 2026
6 checks passed
@atm-snag2
atm-snag2 deleted the remove-direct-webpack-dependency branch October 26, 2026 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants