Repository navigation
fix: cancel agent runs when the HTTP client disconnects - #12
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by mau
Summary
Before: when a client hung up on
POST /v1/chatorPOST /v1/chat/stream, the agent kept running until it finished or hitAGENT_TIMEOUT_MS, still calling the model and tools for nobody. The handlers listened for the request'sabortedevent, but Node doesn't emit it once the request body has been fully read, so the abort signal never fired.After: both endpoints watch the response's
closeevent, and the run is cancelled when the response closes before it finished.How: a small
abortOnDisconnect(response)helper insrc/http.tsreplaces the tworequest.once("aborted")listeners. A new test intests/http.test.tsopens a chat request, destroys the socket while the agent is still running, and checks that the agent's signal is aborted. That test fails onmainand passes with this change.Verification
npm run verify(format, lint, types, tests with coverage, and build all pass locally)