Skip to content

fix(deps): update dependency setuptools to v83 [security] - #55

Open
renovate[bot] wants to merge 1 commit into
mainfrom
renovate/pypi-setuptools-vulnerability
Open

renovate[bot] wants to merge 1 commit into
mainfrom
renovate/pypi-setuptools-vulnerability

Conversation

@renovate

@renovate renovate Bot commented Jul 22, 2026 •

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Confidence
setuptools (changelog) <81 → <84 age confidence

setuptools: MANIFEST.in exclusion bypass in sdist via Unicode normalization collision (NFC/NFD) on macOS APFS/HFS+

CVE-2026-59890 / GHSA-h35f-9h28-mq5c

More information

Details

Summary

When building a source distribution (python -m build --sdist / setup.py sdist), setuptools' FileList applies MANIFEST.in directives (exclude, global-exclude, recursive-exclude, prune) by matching a compiled glob against on-disk file names byte-for-byte, with no Unicode normalization. On normalization-preserving filesystems (notably macOS APFS and HFS+), a file written in NFD and a MANIFEST.in rule written in NFC refer to the same file but are byte-distinct, so the exclusion silently fails to match. A file the maintainer intended to exclude is then packed into the .tar.gz and, if published, uploaded to the public, immutable PyPI index.

Details

File names in FileList.files come from os.walk (setuptools/_distutils/filelist.py, _find_all_simple), so on APFS a file written NFD is offered to the matcher in NFD, while the MANIFEST.in pattern carries the author's editor form (typically NFC). The matching path performs no canonicalization:

##### setuptools/command/egg_info.py  (FileList.global_exclude)
def global_exclude(self, pattern):
    match = translate_pattern(os.path.join('**', pattern))   # fnmatch.translate -> regex, no NFC/NFD
    return self._remove_files(match.match)                   # byte-level regex over raw os.walk names

A rule written NFC (café = 63 61 66 c3 a9) does not match an on-disk name written NFD (café = 63 61 66 65 cc 81), even though the filesystem treats the two as one file.

A unicodedata.normalize('NFD', ...) helper exists in setuptools/unicode_utils.py (decompose()), but it is never called in the manifest matching path, so neither the pattern nor the walked path is normalized before matching. The only normalization in this area, EggInfoCommand._manifest_normalize, uses filesys_decode (bytes→str decode only, no NFC/NFD) and runs when writing SOURCES.txt, after matching has already occurred.

Impact

MANIFEST.in exclusions are the documented mechanism maintainers use to keep secrets, local configs, and private fixtures out of the published sdist. A non-ASCII excluded file may be published to the public, immutable PyPI index despite the rule — an irreversible disclosure with no visual cue (NFC and NFD forms render identically). Exposure is filesystem-dependent and most relevant on macOS APFS/HFS+, where many maintainers build and publish. Pure-ASCII rules are unaffected.

Proof of concept

With a project containing MANIFEST.in:

global-include *.txt *.json
global-exclude secret_café.txt    # rule saved NFC

and an on-disk file secret_café.txt written in NFD, python -m build --sdist packs the secret file into the resulting .tar.gz, while an ASCII control file excluded by the same directive is correctly dropped — isolating the bypass to the NFC-pattern vs. NFD-name mismatch. Reproduced on macOS APFS with setuptools 82.0.1.

Remediation

Normalize both the walked path and each MANIFEST.in pattern to a single canonical form before matching, in both setuptools/command/egg_info.py (FileList) and the vendored setuptools/_distutils/filelist.py. For an exclusion list, err toward excluding more, and document that MANIFEST.in matching is normalization-insensitive on macOS.

Credit

Reported by Tomas Illuminati. Coordinated via CERT/CC VINCE VU#604762.

Severity

  • CVSS Score: 6.1 / 10 (Medium)
  • Vector String: CVSS:3.1/AV:L/AC:L/PR:N/UI:R/S:U/C:H/I:L/A:N

References

This data is provided by the GitHub Advisory Database (CC-BY 4.0).


Release Notes

pypa/setuptools (setuptools)

v83.0.0

Compare Source

v82.0.1

Compare Source

v82.0.0

Compare Source

v81.0.0

Compare Source


Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate
renovate Bot force-pushed the renovate/pypi-setuptools-vulnerability branch from 763b2db to b68baad Compare July 30, 2026 19:46
@renovate renovate Bot changed the title chore(deps): update dependency setuptools to v83 [security] fix(deps): update dependency setuptools to v83 [security] Aug 4, 2026
@renovate
renovate Bot force-pushed the renovate/pypi-setuptools-vulnerability branch from b68baad to ba8ccf3 Compare August 4, 2026 21:47
@bo0tzz
bo0tzz requested a review from mertalev August 5, 2026 13:27
@renovate
renovate Bot force-pushed the renovate/pypi-setuptools-vulnerability branch from ba8ccf3 to 82e75c7 Compare August 12, 2026 02:55
@renovate
renovate Bot force-pushed the renovate/pypi-setuptools-vulnerability branch from 82e75c7 to 0e14e1c Compare August 26, 2026 10:48
@renovate
renovate Bot force-pushed the renovate/pypi-setuptools-vulnerability branch from 0e14e1c to 41563fa Compare September 7, 2026 20:01
@renovate
renovate Bot force-pushed the renovate/pypi-setuptools-vulnerability branch from 41563fa to e40291a Compare September 15, 2026 10:26
@renovate

renovate Bot commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor Author

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: uv.lock
Using CPython 3.12.3 interpreter at: /usr/bin/python3.12
error: No solution found when resolving dependencies for split (markers: python_full_version == '3.12.*' and platform_machine == 'aarch64' and platform_python_implementation != 'CPython' and sys_platform == 'linux'; included: immich-model[rknn]; excluded: immich-model[export])
  cause: Because onnxruntime>=1.19.0 has no `python_full_version < '3.13'`-compatible wheels and only the following versions of onnxruntime are available:
             onnxruntime<1.18.2
             onnxruntime>=1.19.0
         we can conclude that onnxruntime>=1.18.2 cannot be used.
         And because immich-model[rknn] depends on onnxruntime>=1.18.2 and your project requires immich-model[rknn], we can conclude that your project's requirements are unsatisfiable.

hint: The resolution failed for an environment that is not the current one, consider limiting the environments with `tool.uv.environments`.

@renovate
renovate Bot force-pushed the renovate/pypi-setuptools-vulnerability branch from e40291a to 1cea817 Compare September 18, 2026 00:54
@renovate renovate Bot changed the title fix(deps): update dependency setuptools to v83 [security] fix(deps): update dependency setuptools to v84 [security] Sep 18, 2026
@renovate
renovate Bot force-pushed the renovate/pypi-setuptools-vulnerability branch from 1cea817 to 4ff7b36 Compare September 18, 2026 04:22
@renovate renovate Bot changed the title fix(deps): update dependency setuptools to v84 [security] fix(deps): update dependency setuptools to v83 [security] Sep 18, 2026
@renovate
renovate Bot force-pushed the renovate/pypi-setuptools-vulnerability branch 2 times, most recently from 175a8f5 to e88a2eb Compare September 24, 2026 20:59
@renovate
renovate Bot force-pushed the renovate/pypi-setuptools-vulnerability branch from e88a2eb to d2cbe3f Compare October 13, 2026 13:59

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants