Repository navigation
Add style.connectors to draw dashed zoom lines - #9
Merged
Merged
Conversation
A figure-wide style.connectors takes solid (the default) or dashed. Dashed fan lines get a fixed 4 px on, 3 px off pattern through a new dash field on Polyline. The SVG writer adds stroke-dasharray only when a dash is set, so solid drawings stay byte-identical and no existing golden changes. PNG and PDF follow, as they are converted from the SVG. The OTA package example now uses dashed zoom lines; its golden is regenerated. AGENTS.md says connectors only choose solid or dashed, instead of having no keys, and gains a recipe. Add a test for both styles and cover the recipe in test_cli. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A figure-wide
style.connectorsoption:solid(default) ordashed, for the fan lines that connect a zoomed block to its detail column.memmap/schema.py: newStyle.connectors: Literal["solid", "dashed"].memmap/layout/primitives.py:Polylinegets an optionaldash(SVG dash pattern,None= solid).memmap/layout/connectors.py:connector_lines(..., dashed=...)sets a fixedDASH = "4 3"(px on, px off).memmap/render/svg.py: writesstroke-dasharrayonly when a dash is set. PNG and PDF follow, as they are converted from the SVG.Example
examples/ota_package_format.yamlnow usesstyle: { palette: color, connectors: dashed }, and the README row mentions it.Reviewer notes
tests/golden/example_ota_package.svgchanges: its two polylines gainstroke-dasharray="4 3". The real-firmware goldens were regenerated and are unchanged.test_connector_style_sets_the_dash_of_every_fan_linecovers both styles on the F303 example, including that the SVG hasstroke-dasharrayonly when dashed. The new AGENTS.md recipe is checked intests/test_cli.py.uv run pytest(611 passed),uv run mypyanduv run ruff checkpass locally.🤖 Generated with Claude Code