Repository navigation
Add labels.address: none to hide address labels - #8
Merged
Merged
Conversation
A third value for labels.address draws no addresses: not at the column ends, not between blocks and not at unfilled space. An edge with a top_label override still prints its address, so none plus one override labels just that edge. The left gutter shrinks to nothing on its own, as it is sized from the labels; columns with bands keep room for their band numbers. Like the other label options it can be set in view.defaults or on one column. Add the recipe to AGENTS.md and tests for the mode, overrides, the gutter and a single column. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Draw a file format instead of memory: an update package with header, manifest, signature and payload, and a zoom into the header fields. Only order and size matter, so it uses labels.address: none with byte sizes shown. The zoom sits to the left, where the hidden addresses leave room, so its fan lines stay clear of the notes, and is offset down 40 px. Add a golden and a README row. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A third value for
labels.address:nonedraws no address labels, for drawings where only the order and size of blocks matter (file formats, packet layouts, structs).memmap/schema.py:labels.addressacceptsstart | both | none.memmap/layout/labels.py: withnone,build_labelsemits nothing for the column ends, internal edges or edges at unfilled space. An edge with atop_labeloverride still prints, sononeplus one override labels just that edge.view.defaultsor per column, like the other label options. (Expansions take nolabels; set it on the detail column.)Example
New
examples/ota_package_format.yaml: an OTA update package (header, manifest, signature, payload) with a zoom into the header fields, sizes shown and addresses hidden. The zoom sits on the left, where the hidden addresses leave room, so its fan lines stay clear of the notes; it usesoffset: 40.Reviewer notes
start. One new golden:tests/golden/example_ota_package.svg.Hide addresses: view.defaults.labels.address: none), covered bytests/test_cli.py.routing.column_boxstill reserves a line above and below each column for end addresses, so stacked zoom columns with hidden addresses keep a slightly larger gap than they need. Harmless; can be tightened later.uv run pytest(608 passed),uv run mypyanduv run ruff checkpass locally.🤖 Generated with Claude Code