Repository navigation
Fix field-test findings in zoom layout and from-elf - #6
Merged
Merged
Conversation
Layout: - Order detail columns stacked in one lane by where they attach on the source, so their fan lines do not cross, and keep a wider gap between them for both end addresses. - Bend the fan lines of a zoom two or more lanes to the right around the columns in between, moving the detail column up or down as needed. New W107 reports lines that still run through a column; `describe` lists the points of each connector. - Stretch a column that zooms into a much taller stack (up to 5x), from the right so chained zooms measure against grown columns. - Move a stack of zooms that runs past the bottom up to the header row, unless a column in it has an offset. from-elf: - Keil armlink: suffix RW/ZI sections that share a name, detect compressed RW data without mistaking padding or another section for it, and note stored copies. - Draw the Pico SDK's non-allocated (COPY) sections with a note. - Strip the blanks IAR leaves around section names. Tests and docs: routing unit tests, layout regressions, two new real-firmware snapshots (Keil STM32L4, Pico SDK RP2040), section alignment in every snapshot, and AGENTS.md / docs/from-elf.md updates. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from a field test of memmap against datasheet memory maps and real firmware ELFs.
Layout
memmap/layout/routing.py). New W107 reports lines that still run through a column.describe --jsonlists each connector's line points.offset.from-elf
(RW)/(ZI)suffixes. Compressed RW data is detected without mistaking alignment padding or another section for it. Stored copies get a "copied to" or "compressed, unpacked to" note.(COPY)sections (RAM vector table, heap, stacks) are drawn with a note.Tests and docs
tests/test_routing.pycovers the routing geometry.(COPY)import tests.stm32l4_keil_rfe_master(Keil, compressed RW) andrp2040_pico_rom(Pico SDK(COPY)sections).AGENTS.md(W107, layout behaviour,connectors) anddocs/from-elf.mdare updated.Golden changes
Three existing goldens change, all reviewed visually:
example_f303,column_titles: +12 px from the wider stack gap. The end addresses no longer crowd.r52_zephyr_philosophers: shorter. The zooms hang beside their sources, with no empty band at the bottom.docs/examples.svg(README composite, assembled by hand) still shows the old 12 px tighter F303 panel.Checks
uv run pytest(599 passed),uv run mypy,uv run ruff check.🤖 Generated with Claude Code