Repository navigation
General improvements: side panel placeholder and unit tests - #38
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the per-frame dummy session of the side panel and adds unit tests for the non-UI helpers.
Side panel
--for the name and size instead ofUntitledCode
show_sectionhelper for the collapsible sections andshow_file_infofor the file information, which keepsshow_side_panel_contentsshortget_curr_session_mutwould borrow all ofselfTests
selection.rs: address within range in both drag directions and for a single byte,updaterestarting after release vsshift_updateextending from the anchor, blocked selection,clearbyteedit.rs:ByteEdit::clearkeeps the edit marks,remap_modifiedup / down / same addressevents.rs:collect_innerrun in a real egui frame. Text typed with Alt / Ctrl / Cmd is dropped and the filter resets on the next plain key, text and arrows are ignored in a focused text field, arrow order and key repeats, Shift+arrow kept, Escape, Shift and pointer statefingerprint.rs: a00byte at address 0 is detected, a byte changed to the same value, removed start addresshex_input.rs:0bprefixes, binary / decimal digit filters, trailing separator kept while typing, non-ASCII input rejected without panicking