Repository navigation
Hex converter fixes and native window - #37
Merged
Merged
Conversation
iharhl
force-pushed
the
feature/hex-converter-fixes
branch
from
November 17, 2026 19:00
65edc7c to
20fa375
Compare
iharhl
force-pushed
the
feature/hex-converter-fixes
branch
from
November 17, 2026 19:04
20fa375 to
3bf5775
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes wrong results in the hex converter, reworks how it is used, and moves it into its own native window.
Conversion fixes
13330gave Hex3412and Bin4660)FF 00is 255, not negative)-2isFEand-128is80(wereFFFEandFF80).-0is00instead of 16 zero bytes00when the top bit is set, so200is00 C8and reads back as 200\xNN(and\as\\) and reads them back. Before, the·placeholder was read back as UTF-8 (00 41->·A->C2 B7 41).\n,\r,\tand\0are accepted tooInput
>>buttons are gone. Changing Endian or Signed converts the last edited field againDE AD BE EF,de:ad:be:ef,0x1, 0x23(=01 23). Same format as hex search: a group with an odd number of digits (ABC) is ambiguous and shows a warning0bprefix and groups, and keeps the byte width (0000 0001 0000 0000is 2 bytes). Output is grouped by byte-in front of Dec turns Signed on,+turns it off (and is removed)+,#and other symbols are dropped instead of becoming a spaceMessages
Window
Code
hex_input.rsgetssanitize_hex_pattern_inputfor grouped hex input, plus the radix prefix and digit filters. The converter parses hex withparse_hex_patternmain.rs, which is not needed with a separate windowTests
sanitize_hex_pattern_inputKnown limitations
0001-> Dec1-> Hex01