chore(deps): bump the actions group with 3 updates - #83
Conversation
Bumps the actions group with 3 updates: [github/codeql-action](https://github.com/github/codeql-action), [dawidd6/action-send-mail](https://github.com/dawidd6/action-send-mail) and [actions/setup-java](https://github.com/actions/setup-java). Updates `github/codeql-action` from 4.37.7 to 4.37.8 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@v4.37.7...v4.37.8) Updates `dawidd6/action-send-mail` from 3.12.0 to 18 - [Release notes](https://github.com/dawidd6/action-send-mail/releases) - [Commits](dawidd6/action-send-mail@v3.12.0...v18) Updates `actions/setup-java` from 5.7.0 to 6.0.0 - [Release notes](https://github.com/actions/setup-java/releases) - [Commits](actions/setup-java@v5.7.0...v6.0.0) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 4.37.8 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions - dependency-name: dawidd6/action-send-mail dependency-version: '18' dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions - dependency-name: actions/setup-java dependency-version: 6.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions ... Signed-off-by: dependabot[bot] <support@github.com>
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates three GitHub Actions dependencies. While the overall quality grade is up to standards according to Codacy, there are two primary concerns that should be addressed before merging:
- The update for
dawidd6/action-send-mailis a significant major version jump (v3.12.0 to v18). This jump warrants manual verification of SMTP settings as the configuration requirements may have changed. - All actions are currently pinned using tags rather than commit SHAs. In particular, the inconsistency between full semantic versioning for some actions and a major-only tag for others should be resolved by pinning to immutable commit SHAs for better security and reproducibility.
Automated tests for these workflow changes are currently missing.
About this PR
- The update for 'dawidd6/action-send-mail' from v3.12.0 to v18 is a massive major version jump. Please ensure that the current SMTP configuration and workflow parameters remain compatible with v18, as major releases often introduce breaking changes that could silence notification failures.
Test suggestions
- Missing recommended test scenario: Verify CodeQL workflow execution with v4.37.8
- Missing recommended test scenario: Verify push-email-notify workflow successfully sends email with dawidd6/action-send-mail v18
- Missing recommended test scenario: Verify Java environment setup and model-check execution with actions/setup-java v6.0.0
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Missing recommended test scenario: Verify CodeQL workflow execution with v4.37.8
2. Missing recommended test scenario: Verify push-email-notify workflow successfully sends email with dawidd6/action-send-mail v18
3. Missing recommended test scenario: Verify Java environment setup and model-check execution with actions/setup-java v6.0.0
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
| steps: | ||
| - name: Send push notification email | ||
| uses: dawidd6/action-send-mail@v3.12.0 | ||
| uses: dawidd6/action-send-mail@v18 |
There was a problem hiding this comment.
🔴 HIGH RISK
The version for action-send-mail is pinned to a major tag (v18), which is inconsistent with the full semantic versions used elsewhere (e.g., v6.0.0) and represents a security risk. GitHub Actions tags are mutable and can be reassigned, potentially leading to supply chain attacks.
It is recommended to pin the action to a full-length commit SHA for immutability. For example:
uses: dawidd6/action-send-mail@<SHA> # v18
Additionally, verify that the configuration 'with' parameters are still valid for this major version jump.
|
I have addressed the concerns by pinning all actions to their respective commit SHAs for better security and reproducibility. Regarding the |
hyperpolymath
left a comment
There was a problem hiding this comment.
Approving with fixes applied.
Bumps the actions group with 3 updates: github/codeql-action, dawidd6/action-send-mail and actions/setup-java.
Updates
github/codeql-actionfrom 4.37.7 to 4.37.8Release notes
Sourced from github/codeql-action's releases.
Changelog
Sourced from github/codeql-action's changelog.
Commits
db488ddMerge pull request #4102 from github/update-v4.37.8-9ee088e131845f5bUpdate changelog for v4.37.89ee088eMerge pull request #4080 from github/henrymercer/studious-giggle1aef003Address review feedback on overlay disk flags508b83bMerge main into overlay minimum disk feature branchd97b342Merge pull request #4098 from github/mbg/permission-error-as-configuration-error47fa622MakeEACCESaConfigurationError45693ccRefactorENOSPCcheck intoisDiskConfigurationErrorfunctionc2fd8f5Merge pull request #4081 from github/mario-campos/version-cache-to-diskc56f48eLog unexpected conditions during caching CLI outputUpdates
dawidd6/action-send-mailfrom 3.12.0 to 18Release notes
Sourced from dawidd6/action-send-mail's releases.
... (truncated)
Commits
94de994fix: Use extended HELLO with github.com domain (#302)6e50282build(deps): bump actions/checkout from 6 to 7 (#300)1d138f3build(deps): bump nodemailer from 9.0.0 to 9.0.1 (#299)1369c5bnode_modules: update (#297)d86d472build(deps): bump nodemailer from 8.0.11 to 9.0.0 (#296)19dc783build(deps): bump nodemailer from 8.0.10 to 8.0.11 (#295)0dd1be8build(deps): bump nodemailer from 8.0.9 to 8.0.10 (#294)6bf8b9cbuild(deps): bump nodemailer from 8.0.8 to 8.0.9 (#293)51e2c0dbuild(deps): bump nodemailer from 8.0.7 to 8.0.8 (#292)076b075build(deps): bump brace-expansion from 5.0.5 to 5.0.6 (#291)Updates
actions/setup-javafrom 5.7.0 to 6.0.0Release notes
Sourced from actions/setup-java's releases.
... (truncated)
Commits
dd06d9cPrepare documentation for v6 release (#1253)59b3450chore(deps): combine open Dependabot npm updates (#1252)b96213dSet default signature verification for supported distributions (#1246)1dbac3cdocs: expose contributing guide to GitHub (#1245)11741d6ci: constrain cache e2e job modes (#1244)ff99aa1Fix Oracle macOS E2E version (#1243)416c6d1Add Red Hat Build of OpenJDK support (#1241)5f75b27Add Maven dependency-resolution repositories (#1240)a42a52cAdd multiple Maven server credentials (#1239)fb4abd7test: cover JDK 26 from SDKMAN (#1238)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions