Repository navigation
Conversation
DLC 8 was sent as 0 (% 8), payload bytes were written at even indices only, and `id 0x720` read the wrong token. Co-authored-by: Cursor <cursoragent@cursor.com>
Member
|
The commits carry a "Co-authored-by: Cursor cursoragent@cursor.com" trailer, so the change was produced by an AI coding agent. |
Author
|
Your loss, the code is clean, its been fully tested on the hardware, the bug was found by the ai when it was dignosing why your handwritten code wouldnt send ford can messages to an ipc. Merge or dont I dont care, my fw is patched and works, infact im not even running hydrafw on the board now so 🤷 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DLC % 8), so python-can 8-byte frames left the wire as empty IDs (t0480/t7200).data[]indices only;hex2bytealready consumes two hex chars, so a 3-byte UDS frame became02 8E 3Einstead of02 3E 00.id 0x720readtokens[t+3]aftert += 2, which set a garbage ExtId (bench: 1159253378 instead of 1824).Measured on a HydraBus running 0.12 against MS-CAN (125 kbit/s). After the patch, slcan 8-byte frames and
can/id 0x720/write 0x02 0x3E 0x00match the host.Test plan
t720803E00000000000(or python-can 8-byte0x720) appears on the bus as DLC 8, not DLC 0t7203023E00payload on the wire is02 3E 00, not02 8E 3Ecanthenid 0x720reports ID 1824 / 0x720Tframes still parse (DLC nibble at index 9)Made with Cursor