Repository navigation
ci: make Dockerfile the only Ruby/Node pin + bump Ruby - #1198
Draft
gildesmarais wants to merge 5 commits into
Draft
gildesmarais wants to merge 5 commits into
gildesmarais wants to merge 5 commits into
Conversation
The latest 4.0 image is Alpine 3.24, which is what ruby:4.0.8-alpine publishes.
Dependabot's Docker updater only sees literal FROM tags, so drop ARG indirection, .tool-versions, and .devcontainer; run CI and local gates in the digest-pinned multi-stage `dev` image.
gildesmarais
changed the title
gildesmarais
changed the title
gildesmarais
marked this pull request as draft
October 23, 2026 14:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Dockerfileuses literal digest-pinned bases (node:22-alpine@sha256:…,ruby:4.0.8-alpine3.24@sha256:…) with stagesnode→frontend-builder→ruby→dev→builder→runtime.docker-compose.dev.ymlbuildstarget: dev(bind-mount/workspace, bundle volume, ports 4000/4001);bin/compose-contract-verifyasserts that contract.bump-versionrun RuboCop/YARD/RSpec/OpenAPI/frontend/e2e/smoke insidehtml2rss/web:dev(GHA cache); noruby/setup-ruby/actions/setup-node/.tool-versions..tool-versionsand.devcontainer/; Playwright prefers Alpine/usr/bin/chromium; docs/AGENTS.mddescribedocker compose -f docker-compose.dev.yml run --rm dev make ….Why
Dependabot's Docker updater only registers literal
FROM image:tag@sha256:…(dependabot-core#2057). ARG-defaultFROMand a second Ruby pin in.devcontainer/were invisible;.tool-versionshas no Dependabot ecosystem. One root Dockerfile is the version SSOT so Ruby and Node bump viapackage-ecosystem: dockerat/.Risk
devimage; first-run image build cost and Docker socket mount for smoke tests. Productionbuilder/runtimestay no-Node,USER 991. Compose production/quickstart files unchanged.Review map
Dockerfile— digest pins,devNode copy (not full/usr/local), production stages unchanged in intent.github/workflows/ci.yml—devimage build/load +docker runfor ruby/openapi/frontend/smokedocker-compose.dev.yml+bin/compose-contract-verify— localdevcontractAGENTS.md/README.md— Dev Container → composedevwordingValidation
docker run --rm -i hadolint/hadolint < Dockerfile— exit 0bin/compose-contract-verify— passeddocker compose -f docker-compose.dev.yml run --rm dev bash -lc 'make setup && make ci-ready'— exit 0 (RuboCop, RSpec, OpenAPI verify, 3 e2e)