Repository navigation
fix(errors): forward Html2rss::Error diagnostics and keep BLOCKED_SURFACE cacheable - #1194
Merged
Merged
Conversation
…FACE cacheable Move empty_reason and cacheable? onto Decision/RenderResult, extract strategy_attempts from any Html2rss::Error on the cause chain, and document BLOCKED_SURFACE TTL caching so challenge pages are not re-probed every request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ErrorClassifier::Diagnostics.from_errorwalks anyHtml2rss::Errorforattempts/transport_meta(not onlyNoFeedItemsExtracted)Decision#empty_reasonandRenderResult#cacheable?replaceService::EMPTY_REASON_BY_CODEand duplicated cache predicatesBLOCKED_SURFACEstayscacheable: true(documented in classifier +docs/README.md);ConnectionFailedjoinsNETWORK_ERRORSwhen the gem defines itWhy
Post-1.2.5 verification:
feed.renderoften lackedstrategy_attemptson transport terminals, and BLOCKED_SURFACE cache policy needed an explicit product stance (keep cacheable to avoid hammering challenge pages for the feed TTL).Risk
ConnectionFailedclassifier examples areif:-guarded until html2rss ships the class beyond 0.32.3Review map
spec/html2rss/web/error_classifier_spec.rb— diagnostics + BLOCKED_SURFACE policyapp/web/errors/error_classifier.rb— Decision/Diagnosticsspec/html2rss/web/feeds/service_spec.rb/responder_spec.rb— cache + emit shapeValidation
make ready(exit 0; 371 examples)Follow-up
After the companion html2rss gem PR is released and web bumps the pin, drop
const_defined?/if:guards aroundConnectionFailed.