Repository navigation
ci: require an explicit semver for version bumps - #1193
Merged
Merged
Conversation
The bump workflow resolved the version itself, and published notes showed the release steps without a compare link. Dispatch now accepts only X.Y.Z, and those steps stay in an HTML comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
.github/workflows/bump-version.ymlaccepts onlyversion(X.Y.Z). The check matches the whole string, and the bump step reads$TARGET_VERSIONfrom the environment..github/release-drafter.ymlmoves the how-to-release steps into an HTML comment and addscompare/$PREVIOUS_TAG...v$RESOLVED_VERSION.AGENTS.mddispatches withgh workflow run bump-version.yml --ref main -f version=X.Y.Z.Why
The workflow resolved
auto,patch,minor, andmajoron its own, and the draft notes rendered the maintainer steps. The first semver check used line-orientedgrep, so a multilineversioncould overwrite the job output and expand into the bump command.Risk
bump_typeorcustom_versionfail until they passversion.bin/bump-versionstill treatsmajor,minor, andpatchas relative bumps when run directly. The workflow no longer sends those words.Review map
No test delta — start at
.github/workflows/bump-version.yml.Validation
1.4.0,v1.4.0, and1.2.3-rc.1; rejectspatch,auto,minor,major,custom, and a two-line value.