Repository navigation
refactor(telemetry): drop security_event dual-write and error/feeds hulls - #1190
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
SecurityLoggeremits{ event_name, details }only; removessecurity_eventdual-write,reset_logger!, and unusedlog_blocked_request.AppLoggerdrops dead logfmt parsing; gem structured payload uses symbol-keyedevent_nameonly.Auth/FeedToken::Signer: inlinewith_validated_token, fold single-caller hulls, delete unusedSigner.validate.ErrorClassifier: removeSPECIAL_DECISIONS,defined?/respond_to?gem shims; classify the cause chain directly; specs use realHtml2rsserror classes.Feeds::Service/Responder: callContracts::RenderResult.newdirectly; unify failure-details construction.Boot::Setup: inline 1-line private pass-throughs;CONTEXT.md+ specs updated.Why
Single
event_namecontract across the stack; delete dual-write and pre-0.32.2 compatibility hulls that hide contract drift.Risk
security_eventtoevent_name(pair with self-hosted collector PR; re-check OpenObserve after deploy).Review map
spec/html2rss/web/error_classifier_spec.rb— real gem error mappingapp/web/errors/error_classifier.rb— chain classification without shimsapp/web/security/security_logger.rb—event_name-only emitapp/web/telemetry/app_logger.rb— logfmt removalValidation
make readyin Dev Container (html2rss-web_devcontainer-app-1) — exit 0 (re-run before push)