chore(deps): bump twelve npm packages in one branch - #59
Merged
Merged
Conversation
Consolidates this week's five dependabot PRs into one branch. #57 and #58 are two halves of the same vitest 4 -> 5 major: coverage-v8 pins its peer to an exact vitest version, so each half fails `npm ci` with ERESOLVE on its own and neither can merge alone. - react 19.3.0 carries the bundle growth: +29.4 kB raw, +8.7 kB gzip of the +35.1 kB / +10.6 kB total, measured by bumping one package at a time - every one of the twelve is pinned to the version dependabot resolved; npm floated @tanstack/react-virtual and lucide-react past it on re-resolution and both were pinned back - the only lockfile change no dependabot PR carries is dropping @vitest/utils and @vitest/pretty-format, which the vitest 5 tree no longer has a consumer for Co-Authored-By: htjulia <htjulia1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidates this week's five dependabot PRs into one branch, so the tree is
reviewed and merged once instead of five times.
Closes #54
Closes #55
Closes #56
Closes #57
Closes #58
What moves
reactreact-dom@base-ui/react@tanstack/react-virtuallucide-react@types/react@types/react-dom@types/nodeoxlintshadcnvitest@vitest/coverage-v8Two of these could not merge separately at all
#57 (
vitest) and #58 (@vitest/coverage-v8) are two halves of the same major.@vitest/coverage-v8pins its peer to an exact vitest version, so each halfbreaks the other's install. Both PRs failed
lintbefore running a singlecheck, on
npm ci:Neither could go in alone, and merging one would have left the other red until
a dependabot rebase. Together they install clean.
The versions are dependabot's
All twelve are pinned to exactly what dependabot resolved. The combined
vitest-5 tree exists in none of the five branches, so the lockfile had to be
re-resolved once; npm floated two packages past dependabot's pick while doing
it —
@tanstack/react-virtualto 3.14.12 andlucide-reactto 1.45.0 — andboth were pinned back.
Against
main, the only lockfile change that no dependabot branch carries isthe removal of
@vitest/utilsand@vitest/pretty-format. The vitest 5 treehas no consumer left for either; nothing in the lockfile depends on them.
Verification
Full local gate on the merged tree:
npm ci— 444 packages, clean, which is the step that failed on chore(deps-dev): bump vitest from 4.1.11 to 5.0.0 #57/chore(deps-dev): bump @vitest/coverage-v8 from 4.1.11 to 5.0.0 #58.npm run lint— exit 0, 7 warnings, all the pre-existingonly-export-componentsones. oxlint 1.82.0 reports no new diagnostic.npm run build—tsc -bclean. This is what clearslucide-react: everyicon imported across the app still resolves, so the four minors brought no
removal or rename.
npm test— 15 files, 152 tests, all passing on vitest 5.0.0. No test orconfig change was needed;
vitest.config.tsuses nothing the major moved.all draw, every icon present. The only console error is the expected 502 from
the backend on :8080 not running, and the console falls back to sample data
as designed.
Bundle grew, and it is React
481.11 kB → 516.18 kB raw, 152.58 kB → 163.20 kB gzip. Bumping one package at a
time on
mainattributes it:main+ lucide-react 1.43.0+ react/react-dom 19.3.0+ @base-ui/react 1.8.0+ react-virtual, transitivesReact 19.3.0 is ~84% of the growth. It is a single chunk already over the 500 kB
warning line; code-splitting it is its own change, not this one.
Pre-existing, unchanged by this PR
npm auditreports 3 advisories (hono,js-yaml,qs), all reached onlythrough
shadcn→@modelcontextprotocol/sdk. Every one of those transitiveversions is identical on
main— this branch moves none of them, andnpm audit --omit=devreports 0.quota-pressure,retention-limit) flake undervitest run --coverageon both trees — measured 2 failures in 10 runs on thisbranch and 2 in 22 on
main, different tests each time. CI runsnpm testwithout
--coverage, where 10 consecutive runs were clean on both. This istiming sensitivity under instrumentation, not a vitest 5 regression.