Repository navigation
[HSTACK] fix: share filtered-read predicates across fragments - #3
Merged
Merged
Conversation
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
mihai-bleont
approved these changes
Oct 21, 2026
flobinsa
force-pushed
the
fix_large_filters
branch
from
October 21, 2026 12:18
ae330b8 to
0737418
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: share filtered-read predicates across fragments
Before
Filtered-read planning deep-cloned logical predicates for each fragment.
Converting the plan into fragment read tasks cloned them again.
Large predicates, such as long
INlists, multiplied memory usage by thenumber of fragments and could cause OOMs.
After
Fragments share immutable logical predicates through
Arc<Expr>, includingwhen creating read tasks. Filter-selection and evaluation behavior remain
unchanged.
Changes
Arcreferences instead of expression trees for each fragment.ScopedFragmentRead.filters share one allocation.
Validation
from approximately 409 MB to 66 MB.