Skip to content

Update Localized Strings - #6072

Merged
bgoncal merged 2 commits into
mainfrom
create-pull-request/download_strings
Oct 22, 2026
Merged

bgoncal merged 2 commits into
mainfrom
create-pull-request/download_strings

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Automatically created by zacwest.

Copilot AI balanced review requested due to automatic review settings October 15, 2026 06:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Storage guidance contradicts deletion behavior, and the Norwegian door-opening confirmation misstates the action.

2 open findings
What changed in this PR

Updates localization resources for the Home Assistant companion app.

Changes:

  • Adds local-push notification and debugging strings across locales.
  • Expands Norwegian and Korean translations.
  • Revises English storage explanations and matching generated comments, without changing runtime logic.
File Description
Sources/​Shared/​Resources/​Swiftgen/​Strings.swift Updates generated storage comments.
Sources/​App/​Resources/​zh-Hant.lproj/​Localizable.strings Adds local-push strings.
Sources/​App/​Resources/​zh-Hans.lproj/​Localizable.strings Adds local-push strings.
Sources/​App/​Resources/​vi.lproj/​Localizable.strings Adds local-push strings.
Sources/​App/​Resources/​uk.lproj/​Localizable.strings Adds local-push strings.
Sources/​App/​Resources/​tr.lproj/​Localizable.strings Adds local-push strings.
Sources/​App/​Resources/​sv.lproj/​Localizable.strings Adds local-push strings.
Sources/​App/​Resources/​sl.lproj/​Localizable.strings Adds local-push strings.
Sources/​App/​Resources/​ru.lproj/​Localizable.strings Adds local-push strings.
Sources/​App/​Resources/​pt-BR.lproj/​Localizable.strings Adds local-push strings.
Sources/​App/​Resources/​pl-PL.lproj/​Localizable.strings Adds local-push strings.
Sources/​App/​Resources/​nl.lproj/​Localizable.strings Adds local-push strings.
Sources/​App/​Resources/​nb.lproj/​Localizable.strings Expands Norwegian translations; adds local-push strings.
Sources/​App/​Resources/​ml.lproj/​Localizable.strings Adds local-push strings.
Sources/​App/​Resources/​ko-KR.lproj/​Localizable.strings Translates controls; adds local-push strings.
Sources/​App/​Resources/​ja.lproj/​Localizable.strings Adds local-push strings.
Sources/​App/​Resources/​it.lproj/​Localizable.strings Adds local-push strings.
Sources/​App/​Resources/​id.lproj/​Localizable.strings Adds local-push strings.
Sources/​App/​Resources/​hu.lproj/​Localizable.strings Adds local-push strings.
Sources/​App/​Resources/​he.lproj/​Localizable.strings Adds local-push strings.
Sources/​App/​Resources/​fr.lproj/​Localizable.strings Adds local-push strings.
Sources/​App/​Resources/​fi.lproj/​Localizable.strings Adds local-push strings.
Sources/​App/​Resources/​et.lproj/​Localizable.strings Adds local-push strings.
Sources/​App/​Resources/​es.lproj/​Localizable.strings Adds local-push strings.
Sources/​App/​Resources/​es-MX.lproj/​Localizable.strings Adds local-push strings.
Sources/​App/​Resources/​es-ES.lproj/​Localizable.strings Adds local-push strings.
Sources/​App/​Resources/​en.lproj/​Localizable.strings Revises storage explanations.
Sources/​App/​Resources/​en-GB.lproj/​Localizable.strings Adds local-push strings.
Sources/​App/​Resources/​el.lproj/​Localizable.strings Adds local-push strings.
Sources/​App/​Resources/​de.lproj/​Localizable.strings Adds local-push strings.
Sources/​App/​Resources/​da.lproj/​Localizable.strings Adds local-push strings.
Sources/​App/​Resources/​cy-GB.lproj/​Localizable.strings Adds local-push strings.
Sources/​App/​Resources/​cs.lproj/​Localizable.strings Adds local-push strings.
Sources/​App/​Resources/​ca-ES.lproj/​Localizable.strings Adds local-push strings.
Sources/​App/​Resources/​bg.lproj/​Localizable.strings Adds local-push strings.

🧠 Review effort: Balanced


💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

"component.light.set_white" = "Sett hvit";
"component.lock.lock" = "Lås";
"component.lock.open_door" = "Åpne dør";
"component.lock.open_door_confirm" = "Virkelig åpen?";
"settings.debugging.manage_storage.item.frontend_asset_cache.explanation" = "Scripts, styles and images the web view stored for the frontend. They download again on the next load.";
"settings.debugging.manage_storage.item.frontend_asset_cache.title" = "Frontend asset cache";
"settings.debugging.manage_storage.item.legacy_realm_store.explanation" = "Leftover data from an older version of the app. Nothing uses it anymore.";
"settings.debugging.manage_storage.item.legacy_realm_store.explanation" = "The old store zones, notification categories and complications are imported from. It is only kept until that import has run.";
@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor Author

⚠️ Unused L10n strings detected

Found 2 unused localization strings in the codebase.

Click to see details
Parsing Strings.swift...
Found 3072 L10n strings

Reading all Swift source code...
Read 14345596 characters of Swift code

Checking for unused strings...
Checked 100/3072 strings...
Checked 200/3072 strings...
Checked 300/3072 strings...
Checked 400/3072 strings...
Checked 500/3072 strings...
Checked 600/3072 strings...
Checked 700/3072 strings...
Checked 800/3072 strings...
Checked 900/3072 strings...
Checked 1000/3072 strings...
Checked 1100/3072 strings...
Checked 1200/3072 strings...
Checked 1300/3072 strings...
Checked 1400/3072 strings...
Checked 1500/3072 strings...
Checked 1600/3072 strings...
Checked 1700/3072 strings...
Checked 1800/3072 strings...
Checked 1900/3072 strings...
Checked 2000/3072 strings...
Checked 2100/3072 strings...
Checked 2200/3072 strings...
Checked 2300/3072 strings...
Checked 2400/3072 strings...
Checked 2500/3072 strings...
Checked 2600/3072 strings...
Checked 2700/3072 strings...
Checked 2800/3072 strings...
Checked 2900/3072 strings...
Checked 3000/3072 strings...

================================================================================
UNUSED STRINGS REPORT
================================================================================

Found 2 unused strings:


SETTINGS:
  - L10n.Settings.ConnectionSection.connectingVia
    Key: settings.connection_section.connecting_via
    Line: 5363
  - L10n.Settings.ConnectionSection.loggedInAs
    Key: settings.connection_section.logged_in_as
    Line: 5371

================================================================================
Total unused: 2
================================================================================

================================================================================
Copy-paste these keys into the "Lokalise: Delete Keys" workflow (keys input):
================================================================================
settings.connection_section.connecting_via,settings.connection_section.logged_in_as

To remove them, run the
Lokalise: Delete Keys
workflow — it deletes the keys from Lokalise and opens a PR removing them from
Localizable.strings and regenerating Strings.swift. Copy-paste these keys into the keys input:

settings.connection_section.connecting_via,settings.connection_section.logged_in_as

@zacwest
zacwest force-pushed the create-pull-request/download_strings branch 6 times, most recently from 7dd0778 to f1291f4 Compare October 21, 2026 06:09
@zacwest
zacwest force-pushed the create-pull-request/download_strings branch from d0b5373 to 1ceb3ae Compare October 22, 2026 06:10
@codecov

codecov Bot commented Oct 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.06%. Comparing base (d87b0f5) to head (33485b4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6072      +/-   ##
==========================================
+ Coverage   56.71%   57.06%   +0.34%     
==========================================
  Files        1265     1271       +6     
  Lines       83862    84246     +384     
==========================================
+ Hits        47566    48071     +505     
+ Misses      36296    36175     -121     

see 12 files with indirect coverage changes

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bgoncal
bgoncal merged commit e687311 into main Oct 22, 2026
15 checks passed
@bgoncal
bgoncal deleted the create-pull-request/download_strings branch October 22, 2026 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants