Repository navigation
fix: correct adapter review locations and reuse structural reports - #47
Merged
crystalxyz merged 1 commit intoOct 27, 2026
Conversation
anson627
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #36 exposed indistinguishable parity warnings: separate metrics pointed to the first matching JSON field, and rerunning validation posted another full report. Locate findings by entry and metric, include the metric name, and update the latest structural bot comment. Preserve distinct findings and their existing severity.
Serialize structural jobs per PR and check both the current head and published run number before writing. Existing historical duplicate comments remain intact; human comments and Claude reports are not edited.
Validation: all 12 contract tests pass, including one focused repeated-field regression; replaying PR #36 preserves all 10 warnings with the correct locations. The locator handles all 168 valid metadata/parity JSON files. Eight temporary offline publishing simulations cover creation, reruns, ownership, stale heads, closed PRs, and older runs. YAML parses and diff checks pass. No new publishing-test framework is added.
Live workflow validation is deferred until this PR and the separate Claude review guidance PR are merged. No review was triggered on contributor PRs. Devin is outside this change.