Repository navigation
Fix section lookup after a boundary flush - #29
Merged
tbybell merged 3 commits intoOct 18, 2026
Merged
Conversation
Problem: A value lookup at a section's end time also checks the next section, which may contain a later value change at that same time. When trying to read to next section, the code was seeking to the wrong position, causing it to read the current section's header instead of the next section's header. This led to incorrect behavior when the next section was a value change section, later resulting in a heap overflow when parsing the chain table. Solution: read the next section at its actual start and use its header only when it begins at the requested time. AI-assisted
tbybell
approved these changes
Oct 18, 2026
Contributor
|
Thanks. You might want to make sure I didn't accidentally delete any test references/comments in the meson.build and test harness when I resolved mere conflicts. -Tony |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: A value lookup at a section's end time also checks the next section, which may contain a later value change at that same time. When trying to read to next section, the code was seeking to the wrong position, causing it to read the current section's header instead of the next section's header. This led to incorrect behavior when the next section was a value change section, later resulting in a heap overflow when parsing the chain table.
Solution: read the next section at its actual start and use its header only when it begins at the requested time.
AI-assisted