Repository navigation
Fix geometry section being read past its end - #27
Merged
Merged
Conversation
Problem: if the geometry section is shorter than the number of handles it announces, or if it ends on a unterminated varint, the reader will read past the end of the section, causing a heap buffer overflow. Solution: stop when the width run out, and mark the open as failed. Also add a null byte at the end of the geometry section buffer to catch any unterminated varints.
tbybell
approved these changes
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: if the geometry section is shorter than the number of handles it announces, or if it ends on a unterminated varint, the reader will read past the end of the section, causing a heap buffer overflow.
Solution: stop when the width run out, and mark the open as failed. Also add a null byte at the end of the geometry section buffer to catch any unterminated varints.