Repository navigation
Fix frame bounds checks for malformed handles and values - #26
Merged
Merged
Conversation
Problem: A frame can claim more handles than the file has, causing out-of-bounds accesses. Value offsets can also exceed the frame length, with real values potentially reading eight bytes despite a smaller declared width. The RVAT path does not retain the frame length for equivalent checks. Solution: Reject frames with too many handles and validate each value against the frame length using its actual read size. Store the RVAT frame length for the same validation. Also reset `chain_cmem` after freeing it when abandoning a section. AI-assisted
tbybell
approved these changes
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: A frame can claim more handles than the file has, causing out-of-bounds accesses. Value offsets can also exceed the frame length, with real values potentially reading eight bytes despite a smaller declared width. The RVAT path does not retain the frame length for equivalent checks.
Solution: Reject frames with too many handles and validate each value against the frame length using its actual read size. Store the RVAT frame length for the same validation. Also reset
chain_cmemafter freeing it when abandoning a section.AI-assisted