Repository navigation
fix: validate complete FACT judgement coverage before scoring - #374
Open
Cookie0103 wants to merge 1 commit into
Open
Cookie0103 wants to merge 1 commit into
Cookie0103 wants to merge 1 commit into
Conversation
Cookie0103
requested review from
BetterWithBeyti and
andrewtlw
as code owners
November 3, 2026 10:09
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeepResearch Bench FACT currently checks only the number of judge responses before counting citations. For two facts,
[{"idx": 1, "result": "supported"}, {"idx": 1, "result": "supported"}]is accepted and counts the same fact twice, hiding the missing second judgement. A report with one supported and one unsupported fact can therefore receivevalid_rate=1.0.Require each fact's one-based integer index exactly once and a result of
supported,unsupported, orunknown, as requested by the existing prompt. Malformed replies use the existing three-attempt retry/error path. A valid retry in the regression pipeline produces the correctvalid_rate=0.5.What are you adding?
Changes Made
Testing
pytest -m 'not integration'— 403 passed, 1 skipped, 9 deselected. The skip is the existing optionalrank_bm25test; deselected tests require live services.pre-commit run --all-files: all five hooks passed (Ruff check/format, package metadata sync, mypy, isolated registry imports).bench eval --helpas a CLI smoke check.Environment: Python 3.12;
uv sync --dev --group deep_research_bench --python 3.12, then activate.venv. The new test module skips when the optional Google GenAI dependency is unavailable.Checklist
Additional Context
AI assistance disclosure: this patch and its tests were implemented and checked with Codex, including a separate agent code review. The account owner has not personally reviewed or run the tests. No claim is made that live provider output quality or the benchmark's existing policy of excluding unknown/errored groups has changed.