feat(bigtable): Rerouted RowSet and RowRange to use ReadRows from data client - #18196
Open
daniel-sanche wants to merge 3 commits into
Open
feat(bigtable): Rerouted RowSet and RowRange to use ReadRows from data client#18196daniel-sanche wants to merge 3 commits into
daniel-sanche wants to merge 3 commits into
Conversation
daniel-sanche
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors RowSet and RowRange to use ReadRowsQuery and BaseRowRange from the data client, and extracts _MappableAttributesMixin into a shared helper module. The review feedback suggests addressing potential infinite recursion in _MappableAttributesMixin's magic methods and avoiding fragile private attribute access in RowRange.get_range_kwargs by using public properties.
daniel-sanche
force-pushed
the
shim/09-read-rows-row-set
branch
from
September 2, 2026 18:42
406b508 to
06102a1
Compare
daniel-sanche
marked this pull request as ready for review
September 2, 2026 19:16
daniel-sanche
force-pushed
the
shim/09-read-rows-row-set
branch
from
September 2, 2026 19:22
e446a86 to
2677f9a
Compare
daniel-sanche
force-pushed
the
shim/09-read-rows-row-set
branch
from
September 2, 2026 19:58
2677f9a to
69703c3
Compare
**Changes made:** - Refactored `_MappableAttributesMixin` to `helpers.py` for use in `RowRange`. - Used `RowRange` and `ReadRowsQuery` from the data client as backing data sources for `RowRange` and `RowSet` respectively.
daniel-sanche
force-pushed
the
shim/09-read-rows-row-set
branch
from
September 2, 2026 21:58
69703c3 to
8bbec4e
Compare
mutianf
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrating over @gkevinzheng PR from bigtable monorepo googleapis/python-bigtable#1296
Original description:
Note to reviewers: This PR has already been reviewed and merged to a staging branch, with the intention of doing a single merge to main. We are now planning to slowly rollout these changes back to the main branch. Minimal re-review should be necessary