Skip to content

Fix gemini-model node ignoring api key and model changes #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rootkiller6788 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix gemini-model node ignoring api key and model changes #108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions custom_nodes/packages/gemini/src/gemini_model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,11 @@ type NestedArray<T> = T extends Array<any> ? never : Array<T | NestedArray<T>>;
export class GeminiModel extends PureFunctionNode<Inputs, Outputs> {
private genAI?: GoogleGenAI;
private model?: string;
// The API key the current genAI client was built with. The client pins the
// key at construction time, so we need to remember it separately: by the
// time run() fires, PureFunctionNode has already overwritten lastInputs
// with the new inputs, so it can't be used to detect a key change here.
private genAIKey?: string;

constructor() {
super();
Expand All @@ -111,18 +116,20 @@ export class GeminiModel extends PureFunctionNode<Inputs, Outputs> {
throw new Error('Please set your API key');
}

// Rebuild if api key is different.
if (inputs.apiKey !== this.lastInputs?.apiKey || !this.genAI) {
// Rebuild the client when the api key changes. GoogleGenAI keeps using
// the key it was constructed with, so a new key needs a new client.
if (inputs.apiKey !== this.genAIKey || !this.genAI) {
this.genAI = new GoogleGenAI({
apiKey: inputs.apiKey,
});
this.genAIKey = inputs.apiKey;
}

// Get the selected model.
if (!inputs.modelId) {
throw new Error('Please select a model');
}
if (inputs.modelId !== this.lastInputs?.modelId || !this.model) {
if (inputs.modelId !== this.model) {
this.model = inputs.modelId;
}

Expand Down