Skip to content

Allow shard example buffering - #449

Merged
kralka merged 2 commits into
google:mainfrom
kralka:shard_buffering
Nov 4, 2026
Merged

kralka merged 2 commits into
google:mainfrom
kralka:shard_buffering

Conversation

@kralka

@kralka kralka commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

This simplifies compressing the file content and file writing in a separate process.

Part of #444

This simplifies compressing the file content and file writing in a
separate process.
@kralka
kralka marked this pull request as ready for review November 4, 2026 15:06
@kralka
kralka requested a review from jmichelp November 4, 2026 15:06
@kralka
kralka enabled auto-merge November 4, 2026 15:25
@coveralls

coveralls commented Nov 4, 2026 •

Copy link
Copy Markdown

Coverage Report for CI Build 41857485185

Coverage decreased (-0.1%) to 90.557%

Details

  • Coverage decreased (-0.1%) from the base build.
  • Patch coverage: 9 uncovered changes across 3 files (132 of 141 lines covered, 93.62%).
  • 8 coverage regressions across 3 files.

Uncovered Changes

File Changed Covered %
src/sedpack/io/shard/shard_writer_np.py 11 5 45.45%
tests/io/shard/test_shard_writer_base.py 36 34 94.44%
tests/io/test_bytes.py 44 43 97.73%
Total (6 files) 141 132 93.62%

Coverage Regressions

8 previously-covered lines in 3 files lost coverage.

File Lines Losing Coverage Coverage
src/sedpack/io/shard/shard_writer_flatbuffer.py 5 91.46%
src/sedpack/io/shard/shard_writer_np.py 2 74.42%
src/sedpack/io/dataset_filler.py 1 99.01%

Coverage Stats

Coverage Status
Relevant Lines: 3749
Covered Lines: 3395
Line Coverage: 90.56%
Coverage Strength: 0.91 hits per line

💛 - Coveralls

@kralka
kralka added this pull request to the merge queue Nov 4, 2026
Merged via the queue into google:main with commit 6ce713b Nov 4, 2026
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants