Repository navigation
Add J2ObjC proto companion properties for message extensions. - #2909
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
To support forward compatibility with Kotlin/Native proto codegen (`kt_ios_proto_library`) in Objective-C and Swift: - Emit `@property (nonnull, readonly) ComGoogleProtobufGeneratedMessage_GeneratedExtension *<name>;` on `<MessageClass>CompanionProtocol` and the corresponding class getter method on `<MessageClass>` for message-scoped extensions when `generate_properties` is enabled. - Add `typedef ComGoogleProtobufExtensionLite KNPComGoogleProtobufExtensionLite;` in `ExtensionLite.h`. - Add Objective-C and Swift interop tests for message-scoped extensions. PiperOrigin-RevId: 1014722639
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add J2ObjC proto companion properties for message extensions.
To support forward compatibility with Kotlin/Native proto codegen (
kt_ios_proto_library) in Objective-C and Swift:@property (nonnull, readonly) ComGoogleProtobufGeneratedMessage_GeneratedExtension *<name>;on<MessageClass>CompanionProtocoland the corresponding class getter method on<MessageClass>for message-scoped extensions whengenerate_propertiesis enabled.typedef ComGoogleProtobufExtensionLite KNPComGoogleProtobufExtensionLite;inExtensionLite.h.