fix(cli): require OIDC audience when trigger endpoints are enabled - #6994
Open
Tednoob17 wants to merge 1 commit into
Open
fix(cli): require OIDC audience when trigger endpoints are enabled#6994Tednoob17 wants to merge 1 commit into
Tednoob17 wants to merge 1 commit into
Conversation
Tednoob17
force-pushed
the
fix/security/trigger-auth
branch
from
September 2, 2026 18:39
5cd0c4a to
82c6644
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
Problem:
The
/trigger/pubsuband/trigger/eventarcendpoints do not authenticate requests whentrigger_sourcesis enabled but neithertrigger_oidc_audiencenortrigger_auth_verifieris configured. This leaves trigger endpoints unauthenticated.Solution:
Require
trigger_oidc_audienceortrigger_auth_verifierwhenevertrigger_sourcesis set, both at server startup and at deploy time.Testing Plan
Unit Tests:
src/google/adk/cli/test_trigger_auth.pypytest results: 3 passed
Manual End-to-End (E2E) Tests:
N/A for this change.
Checklist