fix(a2a): return long_running_tool_ids from the message and artifact update converters - #6989
Open
Yatsuiii wants to merge 1 commit into
Open
fix(a2a): return long_running_tool_ids from the message and artifact update converters#6989Yatsuiii wants to merge 1 commit into
Yatsuiii wants to merge 1 commit into
Conversation
…update converters _convert_a2a_parts_to_adk_parts recovers long-running function call ids from the is_long_running part marker for all four inbound converters. convert_a2a_message_to_event and convert_a2a_artifact_update_to_event discarded that result and never passed it to _create_event, so the returned Event had long_running_tool_ids=None, while convert_a2a_task_to_event and convert_a2a_status_update_to_event populate it from the same marker. Both are defaults on A2aRemoteAgentConfig, so on the new integration extension path a long-running call arrived looking complete and _should_pause_invocation did not pause. Adds coverage across all four converters. Fixes google#6988
Yatsuiii
force-pushed
the
fix/a2a-inbound-long-running-tool-ids
branch
from
September 2, 2026 18:03
0054de6 to
f9b865d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_convert_a2a_parts_to_adk_partsrecovers long-running function call ids fromthe
is_long_runningpart marker for all four inbound converters. Two of themdiscard the result before building the Event.
_create_eventconvert_a2a_task_to_eventconvert_a2a_status_update_to_eventconvert_a2a_message_to_eventconvert_a2a_artifact_update_to_eventBoth failing sites now keep the ids and pass them positionally, matching the
two that already worked.
Behaviour change
Both are defaults on
A2aRemoteAgentConfig. On the new integration extensionpath
_should_pause_invocationsaw an emptylong_running_tool_idsand didnot pause, so a long-running call ran on as if it had completed. It now pauses,
matching the legacy
event_converterpath.Tests
One parametrized case across all four converters. Without the source change it
fails on
messageandartifact_updateand passes on the other two.tests/unittests/a2ais green: 460 passed, 48 skipped.Fixes #6988