Repository navigation
fix: Accept usage metadata without a total token count - #191
Merged
Merged
Conversation
The API leaves promptTokenCount and totalTokenCount out of the usage metadata in some cases, e.g. for requests with a per-part media resolution. A missing totalTokenCount failed the whole response with a TypeError; it now defaults to 0, like promptTokenCount already did.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API leaves
promptTokenCountandtotalTokenCountout ofusageMetadatain some cases. For example,gemini-2.5-flashwith a per-part media resolution returns:totalTokenCountwas required, so the whole response failed to parse:Fix
Default a missing
totalTokenCountto0, likepromptTokenCountalready is. The property type staysint.Tests
text()works. The test fails without the fix.Verified against the API: the request above failed on
mainand works with this change.