Skip to content

Bump github.com/onsi/ginkgo/v2 from 2.33.1 to 2.34.0 - #267

Merged
github-actions[bot] merged 1 commit into
mainfrom
dependabot/go_modules/github.com/onsi/ginkgo/v2-2.34.0
Nov 6, 2026
Merged

github-actions[bot] merged 1 commit into
mainfrom
dependabot/go_modules/github.com/onsi/ginkgo/v2-2.34.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Nov 6, 2026

Copy link
Copy Markdown
Contributor

Bumps github.com/onsi/ginkgo/v2 from 2.33.1 to 2.34.0.

Release notes

Sourced from github.com/onsi/ginkgo/v2's releases.

v2.34.0

Features

  • DeferOnFailure registers a callback that runs only when a spec fails - as soon as the failing node returns and before any teardown (JustAfterEach, AfterEach, AfterAll, DeferCleanup) - so it can capture the state teardown is about to destroy. It takes exactly what DeferCleanup takes and shares its scoping: called in BeforeEach/JustBeforeEach/It it covers the spec, in BeforeAll the ordered container, and in BeforeSuite the whole suite. It is also available on GinkgoT(); note that this adds a method to FullGinkgoTInterface, so hand-written implementations of that interface need to add it. See https://onsi.github.io/ginkgo/#capturing-failure-state-deferonfailure

Fixes

  • Progress reporters (AttachProgressReporter) are no longer called while Ginkgo holds an internal lock, so a reporter that calls CurrentSpecReport() or AddReportEntry() no longer stalls for 5 seconds and has its output dropped.
  • --sleep-on-failure now runs after any DeferOnFailure callbacks, also pauses when a spec times out, and no longer pauses if the suite has already been interrupted.
Changelog

Sourced from github.com/onsi/ginkgo/v2's changelog.

2.34.0

Features

  • DeferOnFailure registers a callback that runs only when a spec fails - as soon as the failing node returns and before any teardown (JustAfterEach, AfterEach, AfterAll, DeferCleanup) - so it can capture the state teardown is about to destroy. It takes exactly what DeferCleanup takes and shares its scoping: called in BeforeEach/JustBeforeEach/It it covers the spec, in BeforeAll the ordered container, and in BeforeSuite the whole suite. It is also available on GinkgoT(); note that this adds a method to FullGinkgoTInterface, so hand-written implementations of that interface need to add it. See https://onsi.github.io/ginkgo/#capturing-failure-state-deferonfailure

Fixes

  • Progress reporters (AttachProgressReporter) are no longer called while Ginkgo holds an internal lock, so a reporter that calls CurrentSpecReport() or AddReportEntry() no longer stalls for 5 seconds and has its output dropped.
  • --sleep-on-failure now runs after any DeferOnFailure callbacks, also pauses when a spec times out, and no longer pauses if the suite has already been interrupted.
Commits
  • 7035669 v2.34.0
  • 6698926 docs: DeferOnFailure notes for library authors and pause-style callbacks
  • b66a63f Add parallel and JSON integration coverage for DeferOnFailure
  • 07edd04 Precompile the fixtures in the multi-suite timeout integration test
  • db1c4c8 Add DeferOnFailure
  • fba28c7 Query progress reporters without holding selectiveLock
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.33.1 to 2.34.0.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](onsi/ginkgo@v2.33.1...v2.34.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-version: 2.34.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Nov 6, 2026
@github-actions
github-actions Bot enabled auto-merge November 6, 2026 10:32
@github-actions
github-actions Bot merged commit c369063 into main Nov 6, 2026
4 checks passed
@github-actions
github-actions Bot deleted the dependabot/go_modules/github.com/onsi/ginkgo/v2-2.34.0 branch November 6, 2026 10:33
@codecov

codecov Bot commented Nov 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 26.31%. Comparing base (141308c) to head (a3d5add).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #267   +/-   ##
=======================================
  Coverage   26.31%   26.31%           
=======================================
  Files           1        1           
  Lines          76       76           
=======================================
  Hits           20       20           
  Misses         56       56           
Flag Coverage Δ
unittests 26.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants