Repository navigation
fix: preserve cgo constructors during cached package loading - #31
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire could report a missing provider in projects that use cgo, even when the constructor was right there in the source.
The fix makes sure Wire finds those constructors and uses the standard Go package loader when needed. It also refreshes older discovery caches so stale results cannot keep the error around.
Existing projects keep the same public API, generated wiring behavior, and minimum Go version. Regression tests cover fresh and cached discovery, including changes to cgo imports. All 23 checks pass, including Linux, macOS, and Windows in both cache modes.