Skip to content

Update pre-commit tool versions - #1289

Merged
sirosen merged 4 commits into
globus:mainfrom
sirosen:pre-commit-update
Oct 30, 2026
Merged

sirosen merged 4 commits into
globus:mainfrom
sirosen:pre-commit-update

Conversation

@sirosen

@sirosen sirosen commented Oct 13, 2026

Copy link
Copy Markdown
Member

Done in three distinct steps in order to leave a good paper trail:

  • Remove py39 via pyupgrade (also update hook versions)
  • Update flake8-typing-as-t and update to pass
  • Update flake8-bugbear and handle the new B042 rule

Update pre-commit config (autoupdate) and update pyupgrade to use py310+
Under v1.2.0, flake8-typing-as-t flags any typing member access which is
fully superseded: either converted to builtins or deprecated with planned
removal.
Several exceptions fail the B042 rule.
In one case, we can easily update to pass, and in two others type-ignore
comments are the most appropriate immediate solution.
@sirosen sirosen added the no-news-is-good-news This change does not require a news file label Oct 13, 2026
@sirosen
sirosen requested a review from aaschaer as a code owner October 13, 2026 03:31
derek-globus
derek-globus previously approved these changes Oct 30, 2026
@derek-globus
derek-globus dismissed their stale review October 30, 2026 15:50

Whoops, didn't see the full changeset

@derek-globus derek-globus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I've read it all!

@sirosen
sirosen merged commit 7c69421 into globus:main Oct 30, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-news-is-good-news This change does not require a news file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants