Repository navigation
Fix panic when rate limit response has no resources - #144
Merged
Merged
Conversation
RateLimit.Get returns nil rates with no error when a successful response omits the resources object, which caused a nil pointer dereference in Collect and crashed the exporter. Return an error instead, in line with other API failures. Also add regression tests covering issue #77, checking a scrape ends cleanly when any endpoint returns 403. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RateLimit.Get returns nil rates with no error when a successful response omits the resources object, which caused a nil pointer dereference in Collect and crashed the exporter. Return an error instead, in line with other API failures.
Also add regression tests covering issue #77, checking a scrape ends cleanly when any endpoint returns 403.