Repository navigation
chore(deps-dev): Bump @types/node from 24.19.2 to 26.6.6 - #23
dependabot[bot] wants to merge 1 commit into
Conversation
dependabot
Bot
added
dependencies
Evals: passedSuite: copilot-smoke Lint: validated (no model execution) - Evidence Run: passed - 1 trial - Evidence
Quality & token summary
|
| "devDependencies": { | ||
| "@microsoft/vally-cli": "0.19.0", | ||
| "@types/node": "24.19.0", | ||
| "@types/node": "26.6.6", |
There was a problem hiding this comment.
Low: Keep the Node declarations aligned with Node 24
This changes the API definitions used by TypeScript to Node 26, but package.json still requires Node 24, .node-version selects 24.21.0, and action.yml runs the Action on node24. TypeScript can now accept Node 26 APIs that the supported runtime does not provide, so the type check no longer guards against those unsupported calls. The passing checks do not show a current runtime failure; this is a gap in compile-time compatibility checking. Keep @types/node on the 24.x line and regenerate the lockfile while Node 24 remains the supported runtime.
Generated by 🌳Breza Bot
wbreza
left a comment
wbreza
left a comment
There was a problem hiding this comment.
Reviewed #23 at 1c06e0a. Comment — one low-severity issue remains before approval.
Keep the Node type declarations on the supported Node 24 line so type checking continues to match the Action's runtime. See the inline finding.
The manifest and lockfile changes are consistent, and the existing model-free CI checks passed for this head. No current runtime failure was found. I did not run PR scripts or install dependencies locally. The review reaction created by this run was removed.
Generated by 🌳Breza Bot
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the dependency and lockfile update.
No open issues 🎉
1 file not reviewed
pnpm-lock.yaml: Generated file
What changed in this PR
Updates the development-time @types/node package from 24.19.0 to 26.6.6, along with the corresponding pnpm lockfile resolutions.
Changes:
- Bumps
@types/nodeinpackage.json. - Refreshes lockfile entries, including
undici-typesand Vitest/Vite peer resolutions. - Runtime configuration remains on Node 24; the Node 26 type declarations should be aligned with the supported runtime before approval.
This pull request requires changes.
| File | Summary |
|---|---|
package.json |
Updates the @types/node development dependency. Moderate: Node 26 declarations may expose APIs unavailable in the project’s Node 24 runtime; keep the dependency on the Node 24 line or update the runtime configuration together. |
pnpm-lock.yaml |
Records the updated Node.js type package, transitive dependency, and peer-resolution entries. |
Review effort: Lite (auto)
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 24.19.2 to 26.6.6. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-version: 26.6.6 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
changed the title
1c06e0a to
c7e554a
Compare
|
@dependabot ignore this major version
|
|
OK, I won't notify you about version 26.x.x again, unless you re-open this PR. |
Bumps @types/node from 24.19.2 to 26.6.6.
Commits