Repository navigation
Escape replacement values in Gemfile and Composer payloads - #46
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Go's %q emits escapes like \x00 that are not valid JSON, so composer config rejected payloads with control bytes or non-printable Unicode.
andrew
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundler replacements used Go's
%q, which leaves Ruby interpolation active and emits Unicode escapes that Ruby reads differently. Gem names, paths, git URLs and refs are now encoded as Ruby string literals, so supplied values stay literal when the Gemfile is evaluated.Composer repository payloads had the same problem:
%qinside a JSON string emits escapes like\x00that are not valid JSON, socomposer configrejected paths or URLs containing control bytes or non-printable Unicode. The payload is now built withencoding/json.Regression tests cover edited and appended Gemfile entries (interpolation, quotes, backslashes, control bytes, Unicode) and check that Composer payloads parse as JSON and round-trip the original value.