Complete classic S7 management requests and PLC driven download - #904
Merged
Merged
Conversation
gijzelaerr
force-pushed
the
fix/classic-s7-management-download
branch
from
September 30, 2026 12:01
ce95fbb to
912d623
Compare
gijzelaerr
changed the base branch from
fix/classic-s7-response-validation
to
master
September 30, 2026 12:01
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is stacked on #903 because its response and upload validation is required. The matching Lean corpus runner update is lean-s7 #10.
Validation
pytest -q: 1,417 passed, 52 skipped, 5 subtests passed.mypy snap7 s7 tests example: passed.uv run pre-commit run --all-files: passed.