Repository navigation
fix(ci): stop submission workflows running twice on a new issue - #126
Merged
Merged
Conversation
The issue templates apply their label at creation, so `opened` and `labeled` both fired and every new submission ran twice. f525f54 gated the success comment, but the failure comment and the catalog check report still posted twice (#123). Drop `opened`, since a submission's label always arrives with a `labeled` event, and ignore any label other than the workflow's own so a maintainer labelling a failed submission doesn't repeat the failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every new submission ran its workflow twice, because the issue form applies its label at creation and both
openedandlabeledfired. #105 stopped the duplicate success comment, but failures still posted twice. #123 shows it: two identical comments, 6 seconds apart.Applied to all five submission workflows.
openedis removed. A run needs the submission label, and a label present at creation always comes with alabeledevent, soopenedonly added a second run. This also fixes the catalog check failure comment, which doubled the same way.bugto a failed submission would otherwise re-run it and repeat the failure.Evidence
Each workflow's real
build-prscript ran against a mock GitHub with a failing submission, using the event sequence a new issue fires:All five workflows gave the same results. Issue timelines for #123 and #114 show the label's
labeledevent firing at creation for contributors without repo access, and #114's creation shows the same pair of runs.issuesevents only run frommain, so the trigger change can't be exercised live from this branch. The closest real run is thelabeled-only rebuild of #123, which opened #125 and passed validation. The first submission after merge will confirm it.