test(cloudflare): De-flake Workflow auto-instrumentation test - #23829
Open
Lms24 wants to merge 1 commit into
Open
test(cloudflare): De-flake Workflow auto-instrumentation test#23829Lms24 wants to merge 1 commit into
Lms24 wants to merge 1 commit into
Conversation
The scenario emits two transactions — the workflow `step-one` step and the `GET /workflow/trigger` request that triggers it — from separate executions, so which envelope reaches the mock server first is a race. The test expected a single envelope in ordered mode, asserting against whichever arrived first, and failed with `expected 'GET /workflow/trigger' to be 'step-one'` whenever the request transaction won. Expect both transactions with `unordered()`, matching what every other multi-transaction suite in `vite-autoinstrument` already does. This also covers the request transaction, which the test relied on the plugin producing but never asserted. Fixes #23242 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scenario emits two transactions (
step-oneandGET /workflow/trigger) from separate executions, but the test expected one envelope in ordered mode — so it asserted against whichever won the race. Now expects both, unordered.vite-autoinstrumentmulti-transaction suite.Fixes #23242