Skip to content

fix(setup): keep company defaults after resetting setup - #193

Open
artem-broccoli wants to merge 2 commits into
mainfrom
fix/qa-938edf18-reset-defaults
Open

artem-broccoli wants to merge 2 commits into
mainfrom
fix/qa-938edf18-reset-defaults

Conversation

@artem-broccoli

Copy link
Copy Markdown
Contributor

Summary

After Reset setup, approving a self-hosted import skipped Company defaults and Who uses Broccoli, added people immediately and left time off disabled. Existing owners now choose defaults and who uses Broccoli, then finish on the existing final review page. Their account stays in place.

Before: approval skipped the remaining setup pages

Before: reset import left Annual leave not offered

After: Company defaults offered again after reset

After: Company defaults at 390px

Testing

  • Regression tests failed before the fix at the state transition, persisted reset flow and frontend navigation; all pass now.
  • pnpm check, all 1,048 integration tests and all 248 end-to-end tests passed.
  • Development browser: fresh setup, reset and five-person reimport reached Company defaults, Who uses Broccoli and final review. Choices of 25 days and Mon–Thu 8 hours survived reload and Back/reapproval; finishing linked the owner and applied time off (terms after completion). Repeating completion returned a conflict without changes.
  • Production Docker browser: repeated the reset and reimport flow through defaults, Who and final review; verified persisted choices, owner linking and time off. Both deployments passed at desktop and 390px, and both refused repeated completion without changes.

To reproduce, finish self-hosted setup with time off, choose Reset setup, import a new staff file and approve it. Company defaults and Who uses Broccoli should appear before the final review. Finish setup and check the chosen terms and time off are present.

Self-review

Reuses the existing completion operation and pages, removes immediate employee creation from approval and keeps authorization and transaction boundaries (RULE13, RULE19, RULE20, RULE52). No dependencies, migration or AI decision changes. New failure logs carry only caller IDs and safe codes; successful completion is logged after commit (RULE31).

Release Notes:

  • Fixed self-hosted setup skipping company defaults and who uses Broccoli after a reset.

@artem-broccoli
artem-broccoli requested a review from a team as a code owner November 8, 2026 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant