Repository navigation
fix(setup): keep company defaults after resetting setup - #193
Open
artem-broccoli wants to merge 2 commits into
Open
artem-broccoli wants to merge 2 commits into
artem-broccoli wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After Reset setup, approving a self-hosted import skipped Company defaults and Who uses Broccoli, added people immediately and left time off disabled. Existing owners now choose defaults and who uses Broccoli, then finish on the existing final review page. Their account stays in place.
Testing
pnpm check, all 1,048 integration tests and all 248 end-to-end tests passed.To reproduce, finish self-hosted setup with time off, choose Reset setup, import a new staff file and approve it. Company defaults and Who uses Broccoli should appear before the final review. Finish setup and check the chosen terms and time off are present.
Self-review
Reuses the existing completion operation and pages, removes immediate employee creation from approval and keeps authorization and transaction boundaries (RULE13, RULE19, RULE20, RULE52). No dependencies, migration or AI decision changes. New failure logs carry only caller IDs and safe codes; successful completion is logged after commit (RULE31).
Release Notes: