Repository navigation
CI runner fixes - #2418
Merged
Merged
CI runner fixes#2418
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Both changes are narrowly scoped, match the stated intent, and have no identified blocking issues.
No open issues 🎉
What changed in this PR
This PR updates CI runner compatibility and prevents Chromatic publishing from failing when credentials are unavailable.
Changes:
- Update the test job’s Ruby version from 3.1 to 3.4.
- Skip Chromatic publishing when
CHROMATIC_PROJECT_TOKENis empty, while retaining the build.
| File | Description |
|---|---|
.github/workflows/main.yml |
Updates Ruby setup and adds a token guard to Chromatic publishing. |
Review effort: Balanced
dividedmind
force-pushed
the
ci/runner-fixes
branch
from
October 27, 2026 12:13
25b43dd to
bbb81a2
Compare
Pull requests from forks and Dependabot don't receive repository secrets, so the publish step failed there. Keep building the components, but only publish when CHROMATIC_PROJECT_TOKEN is set.
The binary smoke test ran `appmap install` on a scaffolded Ruby project, which made test_native depend on setup-ruby, rubygems.org and the appmap gem's own Ruby version allowlist (appmap 1.1.1 rejects Ruby 3.4, and the runner image no longer has 3.1). `appmap install` is rarely used now anyway. Exercise what the binary is used for instead: build the query DB with `appmap index` and read it back with `appmap query endpoints` and `appmap query tree`. This also covers the bundled better-sqlite3 native addon, the part of the binary most prone to packaging breakage. The test project is now just appmap.yml and the fixture AppMap, so the Ruby setup step goes away. Assisted-by: Claude:claude-opus-5-5
dividedmind
force-pushed
the
ci/runner-fixes
branch
from
October 27, 2026 14:21
bbb81a2 to
73e599a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes:
appmap install) with more current tests (index+query); this also allows dropping the ruby dependency.