You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Restore the Embla-powered Fulldev UI carousel for shadcn parity and responsive multi-card layouts.
The 0.13.0 Data Slot migration intentionally removed fractional slide widths and made every carousel one full-width slide. That broke full.dev's live project rail, where multiple cards are visible and each card contains a link. This PR restores the previous supported contract:
opts API with Embla options and exported CarouselApi, CarouselOptions, CarouselPlugin types
carousel:init and carousel:select events with the Embla API
keyboard, drag, loop, focus scrolling, reduced-motion and Astro page-swap cleanup
no custom observers overriding accessibility state
The earlier multiple and visibility-observer workaround has been removed.
Validation:
pnpm registry:build, pnpm build, pnpm check pass.
12 carousel tests pass across Chromium and WebKit, desktop and mobile: drag, loop, vertical navigation, responsive visible links, keyboard focus and Astro cleanup/reinitialization.
CodeRabbit local review findings were fixed: generated registry output and the carousel's @lucide/astro dependency are current.
Full interaction suite: 112 tests pass.
Clean Astro consumer installs through the registry and builds. Real ClientRouter navigation passes 18 round trips across Chromium/WebKit at 390, 768 and 1440 without page errors or duplicated controls.
Argos build 24: all 48 captures pass; three differences inspected. Two are intended carousel documentation changes; the third is the asynchronous GitHub star count fallback on Pagination.
Sil authorized merging, releasing and consuming this fix for the full.dev rebuild. The full.dev site itself remains a draft.
@coderabbitai Please re-review the current Embla implementation. The observer workaround was removed. Local review findings about generated registry files and the direct icon dependency are resolved; 112 interaction tests pass.
@silveltman I’ll re-review the current Embla implementation. I’ll check the carousel behavior, generated registry files, and direct icon dependency against the latest changes.
⚠️ Action not completed
Pull request is closed.
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
silveltman
changed the title
Restore the Embla-powered Fulldev UI carousel for shadcn parity and responsive multi-card layouts.
The 0.13.0 Data Slot migration intentionally removed fractional slide widths and made every carousel one full-width slide. That broke full.dev's live project rail, where multiple cards are visible and each card contains a link. This PR restores the previous supported contract:
embla-carousel8.6.0, no ReactCarousel,CarouselContent,CarouselItem,CarouselPrevious,CarouselNextcompositionoptsAPI with Embla options and exportedCarouselApi,CarouselOptions,CarouselPlugintypescarousel:initandcarousel:selectevents with the Embla APIThe earlier
multipleand visibility-observer workaround has been removed.Validation:
pnpm registry:build,pnpm build,pnpm checkpass.12 carousel tests pass across Chromium and WebKit, desktop and mobile: drag, loop, vertical navigation, responsive visible links, keyboard focus and Astro cleanup/reinitialization.
CodeRabbit local review findings were fixed: generated registry output and the carousel's
@lucide/astrodependency are current.Full interaction suite: 112 tests pass.
Clean Astro consumer installs through the registry and builds. Real ClientRouter navigation passes 18 round trips across Chromium/WebKit at 390, 768 and 1440 without page errors or duplicated controls.
Argos build 24: all 48 captures pass; three differences inspected. Two are intended carousel documentation changes; the third is the asynchronous GitHub star count fallback on Pagination.
Sil authorized merging, releasing and consuming this fix for the full.dev rebuild. The full.dev site itself remains a draft.