Skip to content

[ci] release - #196

Merged
silveltman merged 1 commit into
mainfrom
changeset-release/main
Sep 26, 2026
Merged

silveltman merged 1 commit into
mainfrom
changeset-release/main

Conversation

@github-actions

@github-actions github-actions Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

fulldev-ui@0.12.0

Minor Changes

  • #195 74fcc47 Thanks @silveltman! - Upgrade all Data Slot primitives and registry dependencies to 1.0.1. Use recommended
    lazy mounting for Select, Tooltip, Hover Card and Navigation Menu, with an explicit
    mountStrategy="eager" opt-in for integrations that query closed content. Discover nested
    comboboxes and hover cards in retained content without duplicate initialization.

    Release outgoing controllers on Astro page swaps so open overlays cannot leave stale
    modal stacks or scroll locks. Give CommandDialog a trigger slot and correct the
    sidebar search composition for strict nested ownership.

    Use native autofocus for command palettes and native link activation for keyboard
    commands. Align Slider defaults and Tabs values with the upstream API, and make
    block dropdown links actual accessible menu items.

    Use shadcn button defaults and consistent overlay layers so nested popups receive
    pointer input. Form submissions should explicitly set type="submit".

    Keep Data Slot modal stack layers and place floating positioners above them so
    Select and other popups remain clickable inside dialogs.

Summary by CodeRabbit

  • New Features
    • Components now mount lazily by default, with an option to mount them eagerly. Existing page content is also discovered when initializing components.
    • Command dialogs and sidebar search have been updated.
  • Bug Fixes
    • Improved keyboard activation, dropdown link accessibility, form submission support, and overlay layering.
    • Improved cleanup when navigating between Astro pages.

@netlify

netlify Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for fulldev-ui ready!

Name Link
🔨 Latest commit 41ba5f0
🔍 Latest deploy log https://app.netlify.com/projects/fulldev-ui/deploys/6ab7ffe64869860007cf1fdb
😎 Deploy Preview https://deploy-preview-196--fulldev-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@silveltman silveltman closed this Sep 26, 2026
@silveltman silveltman reopened this Sep 26, 2026
@argos-ci

argos-ci Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Approved by Sil Veltman (1 comment) 3 changed Sep 26, 2026, 5:27 PM

@coderabbitai

coderabbitai Bot commented Sep 26, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 9ede0be0-0b0d-45fe-a6a4-38dd4738a054

📥 Commits

Reviewing files that changed from the base of the PR and between 74fcc47 and 41ba5f0.

📒 Files selected for processing (4)
  • .changeset/data-slot-one.md
  • .changeset/quiet-ci-permissions.md
  • CHANGELOG.md
  • package.json
💤 Files with no reviewable changes (2)
  • .changeset/data-slot-one.md
  • .changeset/quiet-ci-permissions.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The changelog adds a 0.12.0 release entry that documents dependency upgrades and UI changes. The package version changes from 0.11.1 to 0.12.0. Two changeset files are removed.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other

Suggested reviewers: silveltman

Merge Risk: ⚪ Minimal · up to 41ba5

The release publishes fulldev-ui 0.12.0 with matching minor release notes, and the removed changeset files do not omit another release. No merge-blocking risk was identified.

Architecture Summary

Architecture risk: 🔵 Low · up to 41ba5

The change affects 2 systems.

Changed systems: CHANGELOG.md, package.json

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — CHANGELOG.md (service) was modified; 1 changed file maps to changed impact.
  • observed — package.json (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in CHANGELOG.md: Adds the 0.12.0 Minor Changes release entry, documenting Data Slot and registry dependency upgrades to 1.0.1; lazy mounting for Select, Tooltip, Hover Card, and Navigation Menu with mountStrategy="eager" as an opt-in; discovery of nested comboboxes and hover cards in retained content; controller release on Astro page swaps; CommandDialog trigger-slot and sidebar search composition changes; native autofocus and link activation; Slider and Tabs API alignment; accessible block dropdown links; button defaults, overlay layers, explicit submit types, and modal-stack positioning.
  • observed — Modified behavior in package.json: The package version changes from 0.11.1 to 0.12.0.
  • observed — Modified behavior in .changeset/data-slot-one.md: Removed the fulldev-ui minor changeset describing the Data Slot 1.0.1 upgrade and associated UI changes.
  • observed — Modified behavior in .changeset/quiet-ci-permissions.md: Removed the changeset file’s two --- lines.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title identifies this as a CI release pull request, which matches the package version, changelog, and release metadata changes.
Description check ✅ Passed The description clearly explains the 0.12.0 release and summarizes the included changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@silveltman
silveltman merged commit ade6e2d into main Sep 26, 2026
8 checks passed
@silveltman
silveltman deleted the changeset-release/main branch September 26, 2026 17:29
@silveltman

Copy link
Copy Markdown
Collaborator

Released and validated on production.

  • PR Upgrade Data Slot to 1.0.1 and validate library integration #195 and Changesets release PR [ci] release #196 merged with explicitly authorized admin merge. Repository rules were not changed. Release commit: ade6e2dddf76f0cd31366cda59ece9ece2c4a817.
  • fulldev-ui 0.12.0 published successfully; npm reports latest: 0.12.0. Downloaded the published tarball and verified all 18 Data Slot dependencies are ^1.0.1, with no removed lifecycle helper, consumer fixture, or Data Slot registry item.
  • Production deploy publishes the release commit at ui.full.dev.
  • 84/84 interaction tests passed against the live domain in Chromium and WebKit at desktop 1440×1000 and mobile 390×844, including keyboard/focus, repeated opening/initialization, overlays, lazy content, nested search, navigation, and clipboard success/failure behavior.
  • All 33 affected live registry items plus the registry index match the released generated source exactly. Earlier clean external-consumer validation installed these items with shadcn, built/typechecked, and passed 40 interaction cases; that temporary harness was not retained in the library.
  • Production CI and release workflow passed. Release CodeRabbit review completed on 41ba5f0 with no actionable findings. Argos release build 11 reviewed and approved: the three desktop diffs are only the dynamic GitHub star header, Stars versus 607. Production build 12 is green; its card and command-palette baseline/head/diff image hashes match the reviewed release images.
  • Visible Chrome checks confirmed desktop command-link navigation and repeated mobile sidebar/search opening, search autofocus, Escape closing the child before its parent, and focus returning to Search and then Toggle Sidebar.

Limitations: Playwright WebKit/mobile emulation is not a real iPhone or native Safari test. No screen-reader test. Visible Chrome logged one Astro/browser ViewTransition-aborted message during keyboard navigation; navigation completed and subsequent interactions passed. This upgrade is not evidence that the unreproduced downstream VDA menu issue is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant